| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Stephen Frost <sfrost(at)snowman(dot)net>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Add support for tuple routing to foreign partitions |
| Date: | 2018-03-20 12:31:56 |
| Message-ID: | 20180320123156.tc5z3vxuxzp3brqk@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Amit Langote wrote:
> 2. If I understand the description you provided in [1] correctly, the
> point of having ri_PartitionIsValid and ExecInitExtraPartitionInfo() is to
> avoid possibly-redundantly performing following two steps in
> ExecSetupPartitionTupleRouting() for *reused* partition ResultRelInfos
> that may not be used for tuple routing after all:
>
> - create the parent_child_tupconv_maps[] entry for it
> - perform FDW tuple routing initialization.
>
> If that's true, the following comment could be expanded just a little bit
> to make that clearer:
>
> /*
> * ExecInitPartitionExtraInfo
> * Do the remaining initialization work for the given partition
Yeah, I think the comments on why this is a separate step should be more
extensive. Probably add something to ExecInitPartitionInfo too.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-03-20 12:35:19 | Re: [HACKERS] plpgsql - additional extra checks |
| Previous Message | Andrew Gierth | 2018-03-20 12:11:45 | Re: BUG #15122: can't import data if table has a constraint with a function calling another function |