Re: list partition constraint shape

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: list partition constraint shape
Date: 2018-01-29 06:22:20
Message-ID: 11b673b0-7918-0638-1661-cce55688b1bc@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujita-san,

On 2018/01/29 15:15, Etsuro Fujita wrote:
> (2018/01/29 9:50), Amit Langote wrote:
>> On 2018/01/26 21:31, Etsuro Fujita wrote:
>>> Attached is a modified
>>> version of the patch.  What do you think about that?  Please let me know.
>>> If that is okay, I'll mark this as Ready for Committer.
>>
>> That looks good, thanks.
>
> Cool!  One thing I noticed to revise the patch a bit further is to add an
> assertion to make_partition_op_expr that the number of the right-hand
> inputs to generate an operator expression from for list-partitioning
> should be >=1; in that case we call that function if there is at least one
> non-null partition value as the right-hand input, so that should be
> asserted successfully there.  I think the assertion is a good thing, so I
> modified the patch.

Ah, good call.

>  Updated patch attached.  Because I made no changes
> other than that, I'll make this as Ready for Committer.
Thanks a lot for reviewing.

Regards,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2018-01-29 06:33:58 RE: Temporary tables prevent autovacuum, leading to XID wraparound
Previous Message Etsuro Fujita 2018-01-29 06:19:29 Re: Reorder C includes in partition.c