| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improving isolationtester's data output |
| Date: | 2021-06-16 02:44:29 |
| Message-ID: | 599909.1623811469@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2021-Jun-15, Tom Lane wrote:
>> If we wanted to buy into that, I'd think about discarding this
>> ad-hoc code altogether in favor of using one of libpq's fe-print.c
>> routines. But I'm not really sure that the small legibility gains
>> that would result are worth massive changes in the output files.
> Shrug -- it's a one time change. It wouldn't bother me, for one.
Here's a really quick-and-dirty patch to see what that would look
like. I haven't bothered here to update the expected-files outside
the main src/test/isolation directory, nor to fix the variant files.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| isolationtester-PQprint-output.patch | text/x-diff | 886.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2021-06-16 02:59:47 | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Previous Message | Shinya11.Kato | 2021-06-16 02:17:41 | RE: [PATCH] expand the units that pg_size_pretty supports on output |