| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor code improvement to postgresGetForeignJoinPaths |
| Date: | 2016-10-24 06:45:11 |
| Message-ID: | CAFjFpRftW1eXp3+y78pbF8jxAgE+JATJc3ATJzsJMN_fanVy1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 24, 2016 at 7:56 AM, Tatsuro Yamada
<yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hi,
>
> The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is
> set to NULL, but it would be suitable to set it to NIL because the argument type is List.
>
> Please find attached a patch.
>
You are right. Every call except that one is using NIL, so better to
fix it. The pattern was repeated in the recent aggregate pushdown
support. Here's patch to fix create_foreignscan_path() call in
add_foreign_grouping_paths() as well.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| Attachment | Content-Type | Size |
|---|---|---|
| postgresGetForeignJoinPaths_v2.patch | text/x-diff | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-10-24 06:55:58 | Re: [BUG] pg_basebackup from disconnected standby fails |
| Previous Message | Fabien COELHO | 2016-10-24 06:36:55 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |