| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CI: Add task that runs pgindent |
| Date: | 2025-10-21 15:04:50 |
| Message-ID: | 5782578D-06B7-4609-B61D-1F1B095957EE@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 21 Oct 2025, at 16:31, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
>
> On Tue, 21 Oct 2025 at 15:27, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 21 Oct 2025, at 15:22, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>>
>>> Do you think that this task should format perl files as well?
>>
>> +1, if we do this we should run pgperltidy as well.
>
> I definitely agree that we should run that too. But currently the
> master branch isn't correctly formatted according to pgperltidy (at
> least with the pgperltidy on my machine I get a bunch of changes). So
> I guess koel doesn't complain about that yet,
Indeed there is, I admittedly was under the impression that koel ran pgperltidy
but clearly I was wrong.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Philip Alger | 2025-10-21 15:15:39 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Previous Message | Tom Lane | 2025-10-21 14:57:08 | Re: Client-only Meson Build From Sources |