| From: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CI: Add task that runs pgindent |
| Date: | 2025-10-21 14:31:00 |
| Message-ID: | CAGECzQQSaOp-W6gbNnSdVtNCoOdOiOb+1wO=P8hcC-yvM2Xifg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 21 Oct 2025 at 15:27, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 21 Oct 2025, at 15:22, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> > Do you think that this task should format perl files as well?
>
> +1, if we do this we should run pgperltidy as well.
I definitely agree that we should run that too. But currently the
master branch isn't correctly formatted according to pgperltidy (at
least with the pgperltidy on my machine I get a bunch of changes). So
I guess koel doesn't complain about that yet, and I didn't want to
conflate possible objectsions to that with objections to running
pgindent in CI. Once this CI job is in I wanted to start that
discussion for pgindent (and similarly a discussion on adding a python
formatter/linter).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-10-21 14:36:51 | Re: CI: Add task that runs pgindent |
| Previous Message | Matheus Alcantara | 2025-10-21 14:26:50 | Re: postgres_fdw: Use COPY to speed up batch inserts |