Re: CI: Add task that runs pgindent

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Jelte Fennema-Nio <me(at)jeltef(dot)nl>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-22 04:33:43
Message-ID: aPhep9yW8M3Jghe5@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 21, 2025 at 05:04:50PM +0200, Daniel Gustafsson wrote:
> Indeed there is, I admittedly was under the impression that koel ran pgperltidy
> but clearly I was wrong.

The original thread about forcing a stronger indentation policy was
that we could begin with the C code, leaving everything that is not C
up to the committer who pushes a change.

Another one would be a check on reformat-dat-files. Personally, I
tend to be careful with the dat files, or the indentation of the perl
code before pushing anything. The trend I am seeing is that a lot of
committers are very careful about that as well, so perhaps we could go
one step higher. Fireproof vest is on and ready for impact.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-22 04:49:10 Re: Skip unregistered custom kinds on stats load
Previous Message Masahiko Sawada 2025-10-22 04:31:46 Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue