Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Date: 2015-11-17 23:00:20
Message-ID: 564BB184.5040607@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 11/17/2015 02:15 PM, Tom Lane wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Tue, Oct 13, 2015 at 10:17 PM, Andrew Dunstan wrote:
>>> In general I think we can be a good deal more liberal about backpatching the
>>> testing regime than we are with production code, where we are always
>>> cautious, and the caution has paid big dividends in our reputation for
>>> stability.
>> Attached are patches for 9.4 and 9.5 syncing up everything with
>> master. I tested both of them on OSX, Linux and Windows (MSVC only
>> though using vcregress tapcheck).
> I'm not in a position to double-check that these patches work on Windows,
> but I reviewed them through the expedient of diff'ing the patched files
> against HEAD. The only problem I found was you'd left out the
> documentation addition about needing IPC::Run in install-windows.sgml.
> So I've pushed them with that fix.
>
> Where do we now stand on invoking the TAP tests in the buildfarm?
>
>

This has fallen off my pile a bit :-( I will try to take a good look
over the next 48 hours.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2015-11-18 00:18:54 Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Previous Message Tom Lane 2015-11-17 20:47:33 pgsql: Fix possible internal overflow in numeric division.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-11-17 23:50:37 Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY?
Previous Message Andrew Dunstan 2015-11-17 22:51:12 Re: proposal: multiple psql option -c