Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Date: 2015-11-17 19:15:05
Message-ID: 22416.1447787705@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Oct 13, 2015 at 10:17 PM, Andrew Dunstan wrote:
>> In general I think we can be a good deal more liberal about backpatching the
>> testing regime than we are with production code, where we are always
>> cautious, and the caution has paid big dividends in our reputation for
>> stability.

> Attached are patches for 9.4 and 9.5 syncing up everything with
> master. I tested both of them on OSX, Linux and Windows (MSVC only
> though using vcregress tapcheck).

I'm not in a position to double-check that these patches work on Windows,
but I reviewed them through the expedient of diff'ing the patched files
against HEAD. The only problem I found was you'd left out the
documentation addition about needing IPC::Run in install-windows.sgml.
So I've pushed them with that fix.

Where do we now stand on invoking the TAP tests in the buildfarm?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-11-17 20:47:33 pgsql: Fix possible internal overflow in numeric division.
Previous Message Tom Lane 2015-11-17 19:10:35 pgsql: Back-patch fixes to make TAP tests work on Windows.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-11-17 19:25:25 Re: proposal: multiple psql option -c
Previous Message Robert Haas 2015-11-17 19:14:28 Re: proposal: multiple psql option -c