Re: Better name for PQsslAttributes()

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: lars(at)greiz-reinsdorf(dot)de, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Better name for PQsslAttributes()
Date: 2015-11-06 21:38:45
Message-ID: 563D1DE5.8090002@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/06/2015 11:31 PM, Lars Kanis wrote:
> As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to
> bridge the new SSL related functions to Ruby methods. However I wonder
> whether PQsslAttributes() is the best name for the function. Based on
> this name, I would expect to get key+value pairs instead of only the
> keys. IMHO PQsslAttributeNames() would express better, what the function
> does.

Hmm, I think you're right.

The question is, do we want to still change it? It's a new function in
9.5, and we're just about to enter beta, so I guess we could, although
there might already be applications out there using it. If we do want to
rename it, now is the last chance to do it.

Thoughts? I'm leaning towards changing it now.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2015-11-06 21:40:10 Re: Better name for PQsslAttributes()
Previous Message Lars Kanis 2015-11-06 21:31:52 Better name for PQsslAttributes()