Re: Better name for PQsslAttributes()

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: lars(at)greiz-reinsdorf(dot)de, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Better name for PQsslAttributes()
Date: 2015-11-06 21:40:10
Message-ID: CABUevEwyd6pQXY0O6v_Cq7YUpP6qpq-mdxg2rjctq1Y3tiWPQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 6, 2015 at 10:38 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:

> On 11/06/2015 11:31 PM, Lars Kanis wrote:
>
>> As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to
>> bridge the new SSL related functions to Ruby methods. However I wonder
>> whether PQsslAttributes() is the best name for the function. Based on
>> this name, I would expect to get key+value pairs instead of only the
>> keys. IMHO PQsslAttributeNames() would express better, what the function
>> does.
>>
>
> Hmm, I think you're right.
>
> The question is, do we want to still change it? It's a new function in
> 9.5, and we're just about to enter beta, so I guess we could, although
> there might already be applications out there using it. If we do want to
> rename it, now is the last chance to do it.
>
> Thoughts? I'm leaning towards changing it now.

Uh, just to be clear, we been in beta for a month now, beta1 was released
Oct 8. We are not just about to enter it...

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-11-06 21:41:02 Re: Better name for PQsslAttributes()
Previous Message Heikki Linnakangas 2015-11-06 21:38:45 Re: Better name for PQsslAttributes()