factor out encoding dependent json/jsonb regression tests

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: factor out encoding dependent json/jsonb regression tests
Date: 2015-10-05 17:32:58
Message-ID: 5612B44A.5020601@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm rather tired of having to update two sets of output files every time
we change the json and jsonb regression tests. Also, other committers
occasionally fall over this trap and fail to update json_1.out and
jsonb_1.out, as do almost all other patch authors. I propose that we
remove those tests to quite small json_utf8.sql and jsonb_utf8.sql
(which will each have 2 output files) and that will allow us to get rid
of json_1.out and jsonb_1.out. I'd like to backpatch this to 9.4 for
jsonb and 9.2 for json. Alternatively, for >= 9.4 we could just add the
jsonb encoding-specific tests to json_utf8.sql, to avoid a greater
proliferation of tests.

Thoughts?

cheers

andrew

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-10-05 17:38:27 Re: Less than ideal error reporting in pg_stat_statements
Previous Message Stas Kelvich 2015-10-05 17:29:29 Tsvector editing functions