From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: factor out encoding dependent json/jsonb regression tests |
Date: | 2015-10-05 18:14:44 |
Message-ID: | 20151005181444.GG8531@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan wrote:
> I'm rather tired of having to update two sets of output files every time we
> change the json and jsonb regression tests. Also, other committers
> occasionally fall over this trap and fail to update json_1.out and
> jsonb_1.out, as do almost all other patch authors. I propose that we remove
> those tests to quite small json_utf8.sql and jsonb_utf8.sql (which will each
> have 2 output files) and that will allow us to get rid of json_1.out and
> jsonb_1.out. I'd like to backpatch this to 9.4 for jsonb and 9.2 for json.
+1.
> Alternatively, for >= 9.4 we could just add the jsonb encoding-specific
> tests to json_utf8.sql, to avoid a greater proliferation of tests.
shrug
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2015-10-05 23:56:40 | Re: Multi-tenancy with RLS |
Previous Message | Oleksii Kliukin | 2015-10-05 18:04:47 | Re: run pg_rewind on an uncleanly shut down cluster. |