Re: Logical tape pause/resume

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Claudio Freire <klaussfreire(at)gmail(dot)com>
Subject: Re: Logical tape pause/resume
Date: 2016-10-12 14:30:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 10/10/2016 10:31 PM, Peter Geoghegan wrote:
> On Sun, Oct 9, 2016 at 11:52 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Ok, good. I think we're in agreement on doing this, then, even if we don't
>> agree on the justification :-).
> Agreed. :-)

Attached are new patch versions. Rebased them over current head, fixed a
number of bugs in the seek and backspace code, and did a bunch of
stylistic cleanups and comment fixes.

I changed the API of LogicalTapeBackspace() slightly. If you try to back
up beyond the beginning of tape, it used to return FALSE and do nothing.
Now it backspaces as much as it can, to the very beginning of the tape,
and returns the amount backspaced. That was more convenient than the old
behaviour with this new implementation.

- Heikki

Attachment Content-Type Size
0001-Simplify-tape-block-format.patch text/x-patch 34.6 KB
0002-Pause-resume-support.patch text/x-patch 7.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-10-12 14:49:01 Re: Remove "Source Code" column from \df+ ?
Previous Message Tom Lane 2016-10-12 14:26:10 Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1