| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Claudio Freire <klaussfreire(at)gmail(dot)com> |
| Subject: | Re: Logical tape pause/resume |
| Date: | 2016-12-21 12:25:24 |
| Message-ID: | 2a3b2a16-159e-9ea7-1199-0bf2d3254160@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/12/2016 05:30 PM, Heikki Linnakangas wrote:
> On 10/10/2016 10:31 PM, Peter Geoghegan wrote:
>> On Sun, Oct 9, 2016 at 11:52 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>> Ok, good. I think we're in agreement on doing this, then, even if we don't
>>> agree on the justification :-).
>>
>> Agreed. :-)
>
> Attached are new patch versions. Rebased them over current head, fixed a
> number of bugs in the seek and backspace code, and did a bunch of
> stylistic cleanups and comment fixes.
A rebased set of patches attached.
In the meanwhile, Robert committed the cap on the number of tapes. Since
that's in, I'm not sure if the pause/resume part of this is worthwhile.
Maybe it is.
For now, barring objections, I'm going to commit the first patch. It
seems like a worthwhile simplification in any case, especially for
Peter's Parallel tuplesort patch set.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Simplify-tape-block-format.patch | text/x-patch | 35.7 KB |
| 0002-Pause-resume-support.patch | text/x-patch | 7.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Artur Zakirov | 2016-12-21 12:34:12 | Re: Rethinking our fulltext phrase-search implementation |
| Previous Message | Craig Ringer | 2016-12-21 12:09:56 | Re: Replication slot xmin is not reset if HS feedback is turned off while standby is shut down |