| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: checkpointer continuous flushing |
| Date: | 2015-09-06 17:42:47 |
| Message-ID: | 55EC7B17.7080203@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-09-06 19:05, Fabien COELHO wrote:
>
> Here is a rebased two-part v11.
>
>> function parameters are always in the same line as the function name
>
> ISTM that I did that, or maybe I did not understand what I've done wrong.
>
I see one instance of this issue
+static int
+NextBufferToWrite(
+ TableSpaceCheckpointStatus *spcStatus, int nb_spaces,
+ int *pspace, int num_to_write, int num_written)
Also
+static int bufcmp(const void * pa, const void * pb)
+{
should IMHO be formatted as
+static int
+bufcmp(const void * pa, const void * pb)
+{
And I think we generally put the struct typedefs at the top of the C
file and don't mix them with function definitions (I am talking about
the TableSpaceCheckpointStatus and TableSpaceCountEntry).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2015-09-06 18:27:07 | Re: PL/pgSQL, RAISE and error context |
| Previous Message | Pavel Stehule | 2015-09-06 17:39:57 | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |