Re: checkpointer continuous flushing

Hello Petr,

>>> function parameters are always in the same line as the function name
>>
>> ISTM that I did that, or maybe I did not understand what I've done wrong.
>
> I see one instance of this issue
> +static int
> +NextBufferToWrite(
> + TableSpaceCheckpointStatus *spcStatus, int nb_spaces,
> + int *pspace, int num_to_write, int num_written)

Ok, I was looking for function calls.

> should IMHO be formatted as
> +static int
> +bufcmp(const void * pa, const void * pb)
> +{

Indeed.

> And I think we generally put the struct typedefs at the top of the C file and
> don't mix them with function definitions (I am talking about the
> TableSpaceCheckpointStatus and TableSpaceCountEntry).

Ok, moved up.

Thanks for the hints! Two-part v12 attached fixes these.

--
Fabien.