Re: checkpointer continuous flushing

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: checkpointer continuous flushing
Date: 2015-09-06 18:31:12
Message-ID: alpine.DEB.2.10.1509062014020.30437@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Petr,

>>> function parameters are always in the same line as the function name
>> ISTM that I did that, or maybe I did not understand what I've done wrong.
> I see one instance of this issue
> +static int
> +NextBufferToWrite(
> + TableSpaceCheckpointStatus *spcStatus, int nb_spaces,
> + int *pspace, int num_to_write, int num_written)

Ok, I was looking for function calls.

> should IMHO be formatted as
> +static int
> +bufcmp(const void * pa, const void * pb)
> +{


> And I think we generally put the struct typedefs at the top of the C file and
> don't mix them with function definitions (I am talking about the
> TableSpaceCheckpointStatus and TableSpaceCountEntry).

Ok, moved up.

Thanks for the hints! Two-part v12 attached fixes these.


Attachment Content-Type Size
checkpoint-continuous-flush-12a.patch text/x-diff 20.2 KB
checkpoint-continuous-flush-12b.patch text/x-diff 28.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-09-06 18:34:56 Re: pg_hba_lookup function to get all matching pg_hba.conf entries
Previous Message Joe Conway 2015-09-06 18:27:07 Re: PL/pgSQL, RAISE and error context