Re: pg_stat_statements query jumbling question

From: Satoshi Nagayasu <snaga(at)uptime(dot)jp>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements query jumbling question
Date: 2015-09-01 04:29:29
Message-ID: 55E529A9.5040804@uptime.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015/09/01 12:36, Peter Geoghegan wrote:
> On Mon, Aug 31, 2015 at 8:32 PM, Satoshi Nagayasu <snaga(at)uptime(dot)jp> wrote:
>> Why don't we use relation name (with looking up the catalog)
>> on query jumbling? For performance reason?
>
> I think that there is a good case for preferring this behavior. While
> it is a little confusing that pg_stat_statements does not change the
> representative query string, renaming a table does not make it a
> substantively different table.
>
> There is, IIRC, one case where a string is jumbled directly (CTE
> name). It's usually not the right thing, IMV.
>

Thanks for the comment. I've never considered that. Interesting.

From the users point of view, IMHO, it would be better to avoid
confusing if queryid is determined by only visible values -- userid,
dbid and query string itself.

BTW, I'm interested in improving the queryid portability now because
I'd like to use it in other extensions. :)
That's the reason why I'm looking at query jumbling here.

Thoughts?

Regards,
--
NAGAYASU Satoshi <snaga(at)uptime(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-09-01 04:33:31 Re: WIP: About CMake v2
Previous Message Michael Paquier 2015-09-01 04:24:56 Re: perlcritic