| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, xi(at)resolvent(dot)net, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #13126: table constraint loses its comment |
| Date: | 2015-07-07 09:24:28 |
| Message-ID: | 559B9ACC.2060103@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2015-07-04 13:45, Michael Paquier wrote:
> On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote:
>> Well for indexes you don't really need to add the new AT command, as
>> IndexStmt has char *idxcomment which it will automatically uses as comment
>> if not NULL. While I am not huge fan of the idxcomment it doesn't seem to
>> be easy to remove it in the future and it's what transformTableLikeClause
>> uses so it might be good to be consistent with that.
>
> Oh, right, I completely missed your point and this field in IndexStmt.
> Yes it is better to be consistent in this case and to use it. It makes
> as well the code easier to follow.
> Btw, regarding the new AT routines, I am getting find of them, it
> makes easier to follow which command is added where in the command
> queues.
>
> Updated patch attached.
>
Cool, I am happy with the patch now. Marking as ready for committer.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-07-07 10:14:53 | Re: BUG #13484: Performance problem with logical decoding |
| Previous Message | olivier.gosseaume | 2015-07-07 07:55:50 | Re: BUG #13484: Performance problem with logical decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-07-07 09:25:54 | Re: Transactions involving multiple postgres foreign servers |
| Previous Message | Fujii Masao | 2015-07-07 08:53:35 | Re: [PATCH] Add missing \ddp psql command |