From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, xi(at)resolvent(dot)net, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #13126: table constraint loses its comment |
Date: | 2015-07-08 05:12:59 |
Message-ID: | CAB7nPqTq3eMeQaAPu2q+NWfj8ov-6dOMCt4AqvSGwN16K_=7hw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Tue, Jul 7, 2015 at 6:24 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> On 2015-07-04 13:45, Michael Paquier wrote:
>>
>> On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote:
>>>
>>> Well for indexes you don't really need to add the new AT command, as
>>> IndexStmt has char *idxcomment which it will automatically uses as
>>> comment
>>> if not NULL. While I am not huge fan of the idxcomment it doesn't seem
>>> to
>>> be easy to remove it in the future and it's what transformTableLikeClause
>>> uses so it might be good to be consistent with that.
>>
>>
>> Oh, right, I completely missed your point and this field in IndexStmt.
>> Yes it is better to be consistent in this case and to use it. It makes
>> as well the code easier to follow.
>> Btw, regarding the new AT routines, I am getting find of them, it
>> makes easier to follow which command is added where in the command
>> queues.
>>
>> Updated patch attached.
>>
>
> Cool, I am happy with the patch now. Marking as ready for committer.
Thanks for the review.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Sandeep Thakkar | 2015-07-08 06:07:11 | Re: BUG #12824: Error during uninstall |
Previous Message | Michael Paquier | 2015-07-08 03:49:15 | Re: BUG #13490: Segmentation fault on pg_stat_activity |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-07-08 05:22:49 | Re: dblink: add polymorphic functions. |
Previous Message | Michael Paquier | 2015-07-08 05:11:59 | Re: Set of patch to address several Coverity issues |