Re: BUG #13484: Performance problem with logical decoding

Hi Andres

>>The fix is just to change
>> if (fd == -1 || XLByteInSeg(change->lsn, curOpenSegNo))
>>into
>> if (fd == -1 || !XLByteInSeg(change->lsn, curOpenSegNo))
>>
>>the bug doesn't have any correctness implications afaics, just
>>performance. We read all the spilled files till the end, so even change
>>spilled to the wrong segment gets picked up.
>
>Great. I will try to rebuild on Windows with this patch and let you know

You got it :)

I rebuilt postgres 9.4.4 x64 this morning with your patch in reorderbuffer.c and now it FLIES (140mS for a transaction with 4096 inserts, 600mS for 40960 inserts).

Spilling to disk is now very fast as expected (not even noticeable).

Thanks for your great support.

Will this patch be included in 9.4.5 ?

PS: the build process on Windows is very simple and straightforward, congrats.

Best regards,
Olivier