Re: Adding argument names to aggregate functions

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Adding argument names to aggregate functions
Date: 2023-04-18 08:58:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote:
> Thanks for the heads-up, here's a rebased patch. I've also formatted
> the lines to match what wants. It also wanted to
> reformat a bunch of other entries, but I left those alone.
> - ilmari

The patch applies cleanly now and \df shows the argument names:

postgres=# \df string_agg
                                List of functions
   Schema   |    Name    | Result data type |     Argument data
types      | Type
 pg_catalog | string_agg | bytea            | value bytea, delimiter
bytea | agg
 pg_catalog | string_agg | text             | value text, delimiter
text   | agg
(2 rows)

postgres=# \df json_object_agg
                                List of functions
   Schema   |      Name       | Result data type |  Argument data
types   | Type
 pg_catalog | json_object_agg | json             | key "any", value
"any" | agg
(1 row)

I'm wondering if there are some sort of guidelines that dictate when to
name an argument or not. It would be nice to have one for future reference.

I will mark the CF entry as "Read for Committer" and let the committers
decide if it's best to first create a guideline for that or not.

Best, Jim

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-04-18 09:07:34 Support "Right Semi Join" plan shapes
Previous Message sirisha chamarthi 2023-04-18 08:46:21 Re: Fix documentation for max_wal_size and min_wal_size