Re: Adding argument names to aggregate functions

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Adding argument names to aggregate functions
Date: 2023-04-14 10:03:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> writes:

> On 12.04.23 19:53, Dagfinn Ilmari Mannsåker wrote:
>> Dagfinn Ilmari Mannsåker<ilmari(at)ilmari(dot)org> writes:
>>> Hi hackers,
>>> I'm sure I'm not the only one who can never remember which way around
>>> the value and delimiter arguments go for string_agg() and has to look it
>>> up in the manual every time. To make it more convenient, here's a patch
>>> that adds proargnames to its pg_proc entries so that it can be seen with
>>> a quick \df in psql.
>> Added to the 2023-07 commitfest:
>> - ilmari
> +1 for adding the argument names.
> The patch needs a rebase though.. it no longer applies :
> $ git apply
> ~/Downloads/0001-Add-argument-names-to-multi-argument-aggregates.patch
> error: patch failed: src/include/catalog/pg_proc.dat:8899
> error: src/include/catalog/pg_proc.dat: patch does not apply

Thanks for the heads-up, here's a rebased patch. I've also formatted
the lines to match what wants. It also wanted to
reformat a bunch of other entries, but I left those alone.

- ilmari

Attachment Content-Type Size
v2-0001-Add-argument-names-to-multi-argument-aggregates.patch text/x-diff 2.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2023-04-14 10:05:25 Re: Tab completion for AT TIME ZONE
Previous Message Etsuro Fujita 2023-04-14 09:59:06 Re: Issue in postgres_fdw causing unnecessary wait for cancel request reply