From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Adding argument names to aggregate functions |
Date: | 2023-04-18 09:16:46 |
Message-ID: | d36e168b-7a07-e010-43c1-4a040ec1296c@uni-muenster.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 18.04.23 10:58, I wrote:
> On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote:
>> Thanks for the heads-up, here's a rebased patch. I've also formatted
>> the lines to match what reformat_dat_file.pl wants. It also wanted to
>> reformat a bunch of other entries, but I left those alone.
>>
>> - ilmari
>
> The patch applies cleanly now and \df shows the argument names:
>
> postgres=# \df string_agg
> List of functions
> Schema | Name | Result data type | Argument data
> types | Type
> ------------+------------+------------------+------------------------------+------
>
> pg_catalog | string_agg | bytea | value bytea, delimiter
> bytea | agg
> pg_catalog | string_agg | text | value text, delimiter
> text | agg
> (2 rows)
>
> postgres=# \df json_object_agg
> List of functions
> Schema | Name | Result data type | Argument data
> types | Type
> ------------+-----------------+------------------+------------------------+------
>
> pg_catalog | json_object_agg | json | key "any", value
> "any" | agg
> (1 row)
>
>
> I'm wondering if there are some sort of guidelines that dictate when
> to name an argument or not. It would be nice to have one for future
> reference.
>
> I will mark the CF entry as "Read for Committer" and let the
> committers decide if it's best to first create a guideline for that or
> not.
>
> Best, Jim
>
I just saw that the patch is failing[1] on "macOS - Ventura - Meson".
Not sure if it is related to this patch though ..
[1]
https://api.cirrus-ci.com/v1/artifact/task/5881376021413888/meson_log/build/meson-logs/meson-log.txt
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-04-18 09:50:21 | Re: Incremental sort for access method with ordered scan support (amcanorderbyop) |
Previous Message | Ken Kato | 2023-04-18 09:08:23 | Tab completion for GRANT MAINTAIN |