Re: Declarative partitioning - another take

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Declarative partitioning - another take
Date: 2016-09-06 08:07:33
Message-ID: 4f7108cb-7185-e956-d746-ad756b52431a@lab.ntt.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi,

On 2016/09/06 16:13, Ashutosh Bapat wrote:
> I found a server crash while running make check in regress folder. with
> this set of patches. Problem is RelationBuildPartitionKey() partexprsrc may
> be used uninitialized. Initializing it with NIL fixes the crash. Here's
> patch to fix it. Came up with the fix after discussion with Amit.

Thanks for the report. Here is a rebased version of the patches including
you fix (no significant changes from those posted on Aug 26).

Thanks,
Amit

Attachment Content-Type Size
0001-Catalog-and-DDL-for-partitioned-tables-3.patch text/x-diff 115.9 KB
0002-psql-and-pg_dump-support-for-partitioned-tables-3.patch text/x-diff 22.5 KB
0003-Catalog-and-DDL-for-partitions-3.patch text/x-diff 197.0 KB
0004-psql-and-pg_dump-support-for-partitions-3.patch text/x-diff 17.8 KB
0005-Refactor-optimizer-s-inheritance-set-expansion-code-3.patch text/x-diff 14.5 KB
0006-Teach-a-few-places-to-use-partition-check-quals-3.patch text/x-diff 17.2 KB
0007-Introduce-a-PartitionTreeNode-data-structure-3.patch text/x-diff 8.0 KB
0008-Tuple-routing-for-partitioned-tables-3.patch text/x-diff 40.3 KB
0009-Update-DDL-Partitioning-chapter-to-reflect-new-devel-3.patch text/x-diff 24.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2016-09-06 08:10:08 Re: PATCH: Batch/pipelining support for libpq
Previous Message Pavan Deolasee 2016-09-06 07:52:10 Re: Notice lock waits