| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] taking stdbool.h into use |
| Date: | 2018-02-01 14:04:57 |
| Message-ID: | 4d5235ff-1018-9335-cf1f-810c6fcea95b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/1/18 01:47, Michael Paquier wrote:
> On Wed, Jan 24, 2018 at 03:44:04PM +0900, Michael Paquier wrote:
>> Good catch. Coverage reports mark those areas as empty! Similarly the
>> functions for record_* are mostly not used. Some tests could be added
>> for them at the same time. The four error paths of those functions are
>> tested as well, which is cool to see. Even if the buildfarm explodes
>> after 0002 and 0003, 0001 is still a good addition. The set looks good
>> to me by the way.
>
> OK, so those have been committed as a61116d, 0b5e33f6 and a6ef00b5 for
> the record. The last steps would be to:
> - Introduce bool8 for catalogs.
> - Address GinTernaryValue.
> - Integrate stdbool.h.
> Peter, are you planning to work on that for the next CF?
I've been testing this a bit further and during a test setup with 4-byte
bools I still got regression test failures related to GIN, so it doesn't
seem quite ready. I'll keep working on it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-02-01 14:09:34 | Re: [HACKERS] Can ICU be used for a database's default sort order? |
| Previous Message | Daniel Verite | 2018-02-01 14:01:30 | Re: proposal: alternative psql commands quit and exit |