RE: idle-in-transaction timeout error does not give a hint

From: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
To: 'Tatsuo Ishii' <ishii(at)sraoss(dot)co(dot)jp>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: idle-in-transaction timeout error does not give a hint
Date: 2018-12-03 01:39:54
Message-ID: 4E72940DA2BF16479384A86D54D0988A6F3C1E24@G01JPEXMBKW04
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

>From: Tatsuo Ishii [mailto:ishii(at)sraoss(dot)co(dot)jp]
>
>Hi Ideriha-san,
>
>>>>> Hi, it makes sense to me. One can submit transaction again same as
>>>>> other cases you mentioned.
>>>>>
>>>>> I didn't attach the patch but according to my simple experiment in
>>>>> psql the output would become the following:
>>>>>
>>>>> FATAL: terminating connection due to idle-in-transaction timeout
>>>>> HINT: In a moment you should be able to reconnect to the
>>>>> database and repeat your command.
>>>>
>>>>Alternative HINT message would be something like:
>>>>
>>>>HINT: In a moment you should be able to reconnect to the
>>>> database and restart your transaction.
>>>>
>>>>This could make the meaning of the error (transaction aborted)
>>>>cleaner and might give a better suggestion to the user.
>>>
>>> Agreed. Changing "command" to "transaction" seems more accurate.
>>> People might think only the command they hit is not sent but
>>> transaction is still alive though it's of course unnatural that transaction is alive after
>connection is terminated.

>Please find attached patch which addresses the point above.
Thank you for the update. It looks good to me on this point.
Are you planning to change other similar messages?

>BTW, would you like to be added to the CF item as a reviewer?
Yeah, I've already added myself as a review.

Regards,
Takeshi Ideriha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2018-12-03 01:47:11 Re: [proposal] Add an option for returning SQLSTATE in psql error message
Previous Message Michael Paquier 2018-12-03 00:48:43 Re: Online verification of checksums