Re: idle-in-transaction timeout error does not give a hint

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: idle-in-transaction timeout error does not give a hint
Date: 2018-12-03 04:03:45
Message-ID: 20181203.130345.1717864333333955756.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>>Alternative HINT message would be something like:
>>>>>
>>>>>HINT: In a moment you should be able to reconnect to the
>>>>> database and restart your transaction.
>>>>>
>>>>>This could make the meaning of the error (transaction aborted)
>>>>>cleaner and might give a better suggestion to the user.
>>>>
>>>> Agreed. Changing "command" to "transaction" seems more accurate.
>>>> People might think only the command they hit is not sent but
>>>> transaction is still alive though it's of course unnatural that transaction is alive after
>>connection is terminated.
>
>
>>Please find attached patch which addresses the point above.
> Thank you for the update. It looks good to me on this point.
> Are you planning to change other similar messages?

No, because this is the only message related to an explicit
transaction. Other messages are not related to explicit transactions,
so current messages look ok to me.

>>BTW, would you like to be added to the CF item as a reviewer?
> Yeah, I've already added myself as a review.

Thanks.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2018-12-03 04:05:32 Re: WIP: Avoid creation of the free space map for small tables
Previous Message Andrew Gierth 2018-12-03 03:10:38 Re: AllocSetContextCreate changes breake extensions