Re: Small patch for GiST: move childoffnum to child

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small patch for GiST: move childoffnum to child
Date: 2011-07-13 19:04:48
Message-ID: 4E1DEC50.1060609@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.07.2011 21:56, Alexander Korotkov wrote:
> Thank you very much for detail explanation. But this line of modified patch
> seems strange for me:
> *newchildoffnum = blkno;
> I believe it should be:
> *newchildoffnum = i;

Yes, you're right. It's scary that it worked during testing anyway.
Maybe the resulting tree was indeed broken but it didn't affect the
subsequent inserts so I didn't notice.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-07-13 19:08:37 Re: Need help understanding pg_locks
Previous Message Bruce Momjian 2011-07-13 18:58:43 Re: Need help understanding pg_locks