Re: Need help understanding pg_locks

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florian Pflug <fgp(at)phlo(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Need help understanding pg_locks
Date: 2011-07-13 19:08:37
Message-ID: 201107131908.p6DJ8bB03044@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> On 07/13/2011 12:31 PM, Tom Lane wrote:
> > Bruce Momjian<bruce(at)momjian(dot)us> writes:
> >> Tom Lane wrote:
> >>> I think you misunderstood the suggestion. This is not an improvement,
> >>> it's just more confusion.
> >> Well, I thought the "lock on" wording helped avoid the confusion but
> >> obviously I didn't understand more than that. We did have similar
> >> confusion when we clarified the locking C code. For me, "object" was
> >> the stumbler. Do you have any suggested wording? Everyone seems to
> >> agree it needs improvement.
> > Well, first, "lock object" is completely useless, it does not convey
> > more than "lock" does; and second, you've added confusion because the
> > very same sentences also use "object" to refer to the thing being
> > locked.
> >
>
>
> Maybe "lock" for the lock itself and "lock target" for the thing locked,
> or some such, would work.
>
> I agree that "object" on its own is not a terribly helpful term. It's
> too often shorthand for "whatever-it-is".

Agreed.

OK, new wording based on the comments above; attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/lock2.diff text/x-diff 3.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-07-13 19:12:12 Re: Tweaking the planner's heuristics for small/empty tables
Previous Message Heikki Linnakangas 2011-07-13 19:04:48 Re: Small patch for GiST: move childoffnum to child