From: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: renameatt() can rename attribute of index, sequence, ... |
Date: | 2010-03-12 00:19:48 |
Message-ID: | 4B9988A4.7090909@ak.jp.nec.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
(2010/03/11 23:55), Robert Haas wrote:
> 2010/3/10 KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>> Indeed, it is useful to allow renaming attribute of composite types.
>>
>> However, it is also useless to allow to rename attribute of sequences,
>> but harmless, like renames on indexes. It seems to me it is fair enough
>> to allow renaming attributes of tables, views and composite types...
>
> I don't agree. I think users should be allowed to rename things they
> had a hand in naming in the first place (and index columns fall into
> that category, since the names are derived from table column names).
> But changing system-assigned column names for sequences or toast
> tables is just weird.
OK, the attached patch forbid to rename an attribute of relations except
for tables, views, composite types and indexes.
Thanks,
--
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Attachment | Content-Type | Size |
---|---|---|
pgsql-renameatt-check-relkind.2.patch | application/octect-stream | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gurjeet Singh | 2010-03-12 00:40:57 | Re: log : bad file dscriptor???? |
Previous Message | Tom Lane | 2010-03-11 23:57:10 | buildfarm logging versus embedded nulls |