Re: renameatt() can rename attribute of index, sequence, ...

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: renameatt() can rename attribute of index, sequence, ...
Date: 2010-03-13 01:08:23
Message-ID: 603c8f071003121708rdbb1bbeu1fe1277f61aa066b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2010/3/11 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> (2010/03/11 23:55), Robert Haas wrote:
>> 2010/3/10 KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>> Indeed, it is useful to allow renaming attribute of composite types.
>>>
>>> However, it is also useless to allow to rename attribute of sequences,
>>> but harmless, like renames on indexes. It seems to me it is fair enough
>>> to allow renaming attributes of tables, views and composite types...
>>
>> I don't agree.  I think users should be allowed to rename things they
>> had a hand in naming in the first place (and index columns fall into
>> that category, since the names are derived from table column names).
>> But changing system-assigned column names for sequences or toast
>> tables is just weird.
>
> OK, the attached patch forbid to rename an attribute of relations except
> for tables, views, composite types and indexes.

I would like to apply this for 9.0, with some adjustments to the
comments. Objections?

...Robert

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-03-13 01:09:32 Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores
Previous Message Alvaro Herrera 2010-03-13 00:55:51 Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores