Re: handling contrib directories as modules not shared libraries

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Brook Milligan <brook(at)biology(dot)nmsu(dot)edu>
Cc: pgsql-hackers(at)postgresql(dot)org, brook(at)nmsu(dot)edu
Subject: Re: handling contrib directories as modules not shared libraries
Date: 2010-01-25 18:52:56
Message-ID: 4B5DE888.8010304@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/23/10 5:00 PM, Brook Milligan wrote:
> It seems that src/Makefile.shlib has special cases for several
> directories that build loadable modules rather than shared libraries.
> The contrib/adminpack is one of the special cases, but none of the
> other contrib directories are. As a result, they get built as shared
> libraries (i.e., as libXXX.so rather than XXX.so) and the
> corresponding *.sql.in files that load them refer to the wrong file
> and therefore fail. The following patch (against the 8.3 release)
> fixes this by expanding the set of special cases to include all the
> contrib directories, not just contrib/adminpack. I only have tested
> this with the uuid module, but it appears that all of them have the
> same organization.

Should we be fixing them this way, or fixing the modules so that they
build as shared libraries?

--Josh Berkus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2010-01-25 18:53:01 Re: Clustering Docs WAS: Mammoth in Core?
Previous Message Boszormenyi Zoltan 2010-01-25 18:52:05 Re: ECPG patch 4.1, out-of-scope cursor support in native mode