handling contrib directories as modules not shared libraries

From: brook(at)biology(dot)nmsu(dot)edu (Brook Milligan)
To: pgsql-hackers(at)postgresql(dot)org
Cc: brook(at)nmsu(dot)edu
Subject: handling contrib directories as modules not shared libraries
Date: 2010-01-24 01:00:51
Message-ID: 20100124010051.5A9331177E2D@viola.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It seems that src/Makefile.shlib has special cases for several
directories that build loadable modules rather than shared libraries.
The contrib/adminpack is one of the special cases, but none of the
other contrib directories are. As a result, they get built as shared
libraries (i.e., as libXXX.so rather than XXX.so) and the
corresponding *.sql.in files that load them refer to the wrong file
and therefore fail. The following patch (against the 8.3 release)
fixes this by expanding the set of special cases to include all the
contrib directories, not just contrib/adminpack. I only have tested
this with the uuid module, but it appears that all of them have the
same organization.

--- src/Makefile.shlib.orig
+++ src/Makefile.shlib
@@ -21,7 +21,7 @@
ifneq (,$(findstring src/pl/,$(subdir)))
shmodule = yes
else
-ifneq (,$(findstring contrib/adminpack,$(subdir)))
+ifneq (,$(findstring contrib/,$(subdir)))
shmodule = yes
else
shmodule = no

Cheers,
Brook

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2010-01-24 01:33:40 Re: restructuring "alter table" privilege checks (was: remove redundant ownership checks)
Previous Message Andrew Dunstan 2010-01-24 00:59:14 Re: commit fests