From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org> |
Subject: | Re: Path separator |
Date: | 2009-04-12 07:53:33 |
Message-ID: | 49E19DFD.4010701@hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Answering myself here: the filesize for the "frontend only" part is
>>> about 2k on this system.
>
>> Long meeting, time for coding.. :-) Here's a rough patch. Is this about
>> what you had in mind?
>
> Hm, this seems to make the namespace pollution problem worse not better,
> because of de-staticizing so many functions. I guess we could stick pg_
> prefixes on all of them. That's a bit ugly; anybody have a better idea?
Not really.
> It might be that it'd be better to push a couple more of the simple
> path-munging functions (like join_path_components) over into the new
> file, so as to have a more logical division of responsibilities.
> In my mind the two key areas here are "path syntax knowledge" and
> "extracting absolute paths from environmental information". The second
> part seems to be the one that doesn't belong on the frontend side.
What would be the gain there? To be able to re-static-ify for example
skip_drive? Or just a nicer division?
We should probably also consider moving get_home_path() over to the
frontend one, and get rid of the copy that's in fe-connect.c.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2009-04-12 09:30:42 | Re: [pgtranslation-translators] on gettext plural support |
Previous Message | Robert Haas | 2009-04-12 04:00:36 | HashJoin w/option to unique-ify inner rel |