Re: pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: mha(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Subject: Re: pgsql: Explicitly bind gettext() to the UTF8 locale when in use.
Date: 2008-11-24 01:34:17
Message-ID: 492A0499.1010601@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Magnus and all,

Magnus Hagander wrote:
> Log Message:
> -----------
> Explicitly bind gettext() to the UTF8 locale when in use.
> This is required on Windows due to the special locale
> handling for UTF8 that doesn't change the full environment.

Thanks to this change UTF-8 case was solved but Japanese users
are still unhappy with Windows databases with EUC_JP encoding.
Shift_JIS which is a Japanese encoding under Windows doesn't
match any server encoding and causes a crash with the use of
gettext. So Saito-san removed ja message catalog just before
the 8.3 release.

Attached is a simple patch to avoid the crash and enable the
use of Japanese message catalog.
Please apply the patch if there's no problem.

regards,
Hiroshi Inoue

> Fixes crash with translated error messages per bugs 4180
> and 4196.
>
> Tom Lane
>
> Modified Files:
> --------------
> pgsql/src/backend/utils/mb:
> mbutils.c (r1.70 -> r1.71)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/mbutils.c?r1=1.70&r2=1.71)

Attachment Content-Type Size
mbutils.patch text/plain 904 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Fxjr 2008-11-24 03:08:57 npgsql - Npgsql: Fixed problem when calling functions with inout or
Previous Message User H-saito 2008-11-23 03:12:34 psqlodbc - psqlodbc: The specification method of the ROLLBACK option is

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2008-11-24 04:13:19 Re: [PATCHES] Solve a problem of LC_TIME of windows.
Previous Message Matthew T. O'Connor 2008-11-23 22:28:51 Re: Visibility map, partial vacuums