Re: [PATCHES] Solve a problem of LC_TIME of windows.

From: "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
To: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Magnus Hagander" <magnus(at)hagander(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows.
Date: 2008-11-24 04:13:19
Message-ID: 3073cc9b0811232013q1a295432o1ec582b87a89ecc9@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sun, Nov 16, 2008 at 8:36 AM, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> wrote:
> Hi.
>
> Then, It continues and a review is desired. Thanks!
>

In http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx says:
"""
Return Value
strftime returns the number of characters placed in strDest and
wcsftime returns the corresponding number of wide characters.
If the total number of characters, including the terminating null, is
more than maxsize, both strftime and wcsftime return 0 and the
contents of strDest is indeterminate.
"""

If i'm reading it right, the patch should contain something like:

if (len > dstlen)
{
return 0;
}

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Saito 2008-11-24 07:02:08 Re: [PATCHES] Solve a problem of LC_TIME of windows.
Previous Message Hiroshi Inoue 2008-11-24 01:34:17 Re: pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2008-11-24 07:02:08 Re: [PATCHES] Solve a problem of LC_TIME of windows.
Previous Message Simon Riggs 2008-11-20 10:10:05 Re: [PATCHES] Infrastructure changes for recovery (v8)