| From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Date: | 2025-07-10 17:41:11 |
| Message-ID: | 4904EA5B-C6CA-42BD-BF08-C89325240C9D@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 14 Jun 2025, at 6:08 PM, David E. Wheeler <david(at)justatheory(dot)com> wrote:
>
> On Jun 4, 2025, at 11:27, David E. Wheeler <david(at)justatheory(dot)com> wrote:
>
>> And these should fix the CI failure. I also ran pgindent.
>
> Here’s a quick rebase. I think it’s ready for committer review, but since I’ve poked at it quite a bit myself, I updated the Commitfest item [1] to “Needs Review”.
>
> Best,
>
> David
>
> [1]: https://commitfest.postgresql.org/patch/5270/
>
> <v9-0001-Rename-jsonpath-method-arg-tokens.patch><v9-0002-Add-additional-jsonpath-string-methods.patch>
>
The basic problem I see with these latest revisions/refactorings is that they fail for pg_upgrade afaict.
Probably this means that some of the rearrangements on the parser/scanner are not that flexible.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-07-10 17:42:26 | Re: pg_dump --with-* options |
| Previous Message | Dimitrios Apostolou | 2025-07-10 17:39:10 | Re: [PING] fallocate() causes btrfs to never compress postgresql files |