Re: Buildfarm not happy with test module move

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Buildfarm not happy with test module move
Date: 2014-12-01 01:22:00
Message-ID: 4770.1417396920@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> All of the MSVC critters are failing at "make check".

> Yeah, I noticed that, thanks. As far as I can see the only way to fix
> it is to install dummy_seclabel to run the core seclabel test. That
> doesn't seem smart; I think it'd be better to remove that part of the
> core seclabel test, and move the rest of the test to a new test in the
> dummy_seclabel module.

Sounds good to me. The other parts of the core tests that depend on
contrib modules aren't exactly good models to follow.

> That was my fault -- the alvh.no-ip.org domain was deleted, and the
> email system in postgresql.org rejected the commit message because the
> sender was not in a deliverable domain. I noticed within a few hours,
> but the damage was already done.

I guess I'm confused about which is your preferred email address?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-12-01 01:49:51 Re: 9.5: Better memory accounting, towards memory-bounded HashAgg
Previous Message Peter Geoghegan 2014-12-01 01:16:51 Re: Doing better at HINTing an appropriate column within errorMissingColumn()