| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 9.5: Better memory accounting, towards memory-bounded HashAgg |
| Date: | 2014-12-01 01:49:51 |
| Message-ID: | CAM3SWZT5Qj2m-Rf8UOgvmQVw_2HoN1V5ZpFAoO_rHskaBHoUGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 17, 2014 at 11:39 PM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> I can also just move isReset there, and keep mem_allocated as a uint64.
> That way, if I find later that I want to track the aggregated value for
> the child contexts as well, I can split it into two uint32s. I'll hold
> off any any such optimizations until I see some numbers from HashAgg
> though.
I took a quick look at memory-accounting-v8.patch.
Is there some reason why mem_allocated is a uint64? All other things
being equal, I'd follow the example of tuplesort.c's
MemoryContextAllocHuge() API, which (following bugfix commit
79e0f87a1) uses int64 variables to track available memory and so on.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2014-12-01 02:46:51 | Re: Proposal: Log inability to lock pages during vacuum |
| Previous Message | Tom Lane | 2014-12-01 01:22:00 | Re: Buildfarm not happy with test module move |