| From: | Dave Page <dpage(at)postgresql(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Rainer Bauer <usenet(at)munnin(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent |
| Date: | 2007-12-10 09:56:39 |
| Message-ID: | 475D0D57.2040905@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Dave Page wrote:
> Tom Lane wrote:
>> Dave Page <dpage(at)postgresql(dot)org> writes:
>>> Gregory Stark wrote:
>>>> An alternative is leaving it in the project file but putting
>>>> something like
>>>> this in c.h:
>>
>> Put it in win32.h, please. c.h shouldn't get cluttered with
>> platform-specific kluges when there's no need for it.
>>
>> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?
>
> Yeah, the fact that addons may then end up partially compiled with and
> partially without it being defined. It we just have it error as Greg
> suggested, then it will force the authors to define it themselves, and
> if they get that wrong it's their fault not ours.
Patch attached.
/D
| Attachment | Content-Type | Size |
|---|---|---|
| 32bit_time_t-2.diff | text/x-patch | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-12-10 10:08:42 | Re: Release Note Changes |
| Previous Message | Dimitri Fontaine | 2007-12-10 08:51:45 | Re: Release Note Changes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2007-12-10 12:39:05 | Re: PGparam timestamp question |
| Previous Message | Michael Meskes | 2007-12-10 08:08:07 | Re: PGparam timestamp question |