Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, Rainer Bauer <usenet(at)munnin(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent
Date: 2007-12-11 14:35:13
Message-ID: 20071211143513.GL31937@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, Dec 10, 2007 at 09:56:39AM +0000, Dave Page wrote:
> Dave Page wrote:
> > Tom Lane wrote:
> >> Dave Page <dpage(at)postgresql(dot)org> writes:
> >>> Gregory Stark wrote:
> >>>> An alternative is leaving it in the project file but putting
> >>>> something like
> >>>> this in c.h:
> >>
> >> Put it in win32.h, please. c.h shouldn't get cluttered with
> >> platform-specific kluges when there's no need for it.
> >>
> >> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?
> >
> > Yeah, the fact that addons may then end up partially compiled with and
> > partially without it being defined. It we just have it error as Greg
> > suggested, then it will force the authors to define it themselves, and
> > if they get that wrong it's their fault not ours.
>
> Patch attached.

Applide with two tiny modifications - the missing quote taht you mentioned,
and changed the #ifdef to only affect MSVC and not mingw.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-12-11 14:41:53 Re: Document how to turn off disk write cache on popular operating
Previous Message Martijn van Oosterhout 2007-12-11 14:33:53 Re: VACUUM ANALYZE out of memory

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-12-12 02:52:24 Proposed patch to avoid translation risks in psql's \d commands
Previous Message Zdenek Kotala 2007-12-11 14:27:04 DOC: Wal update