Fix pg_dump dependency on postgres.h

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Fix pg_dump dependency on postgres.h
Date: 2007-11-06 13:22:09
Message-ID: 47306A81.60402@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Attached patch removes pg_dump dependency on postgres.h. The main reason
for that was discussed there:

http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php

This fix contains several steps:

1) I removed sugar word from postgres.h and put them closer to consumer
:-). I created include/catalog/genbki.h which contains sugar words -
macros for correct catalog data processing. All catalogs file now
include this header.

2) I moved SEQ_MAXVALUE and SEQ_MINVALUE macros from sequence.h to
postgres_config_manual.h

3) I created two new headers pg_type_fn.h and pg_proc_fn.h and I moved
all extern function definition from related headers into them. Second
possible solution could be let function definition into headers and
fence them by #ifndef FRONTED.

Let me know your comments.

Thanks
Zdenek

Attachment Content-Type Size
pg_dump.patch.gz application/x-gzip 6.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2007-11-06 13:24:59 Re: Visibility map thoughts
Previous Message Marko Kreen 2007-11-06 13:19:16 Re: Visibility map thoughts

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-11-06 14:27:07 Re: krb_match_realm
Previous Message Tom Lane 2007-11-05 20:58:05 Re: compiler warning fix