From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fix pg_dump dependency on postgres.h |
Date: | 2007-11-06 16:58:05 |
Message-ID: | 20071106165805.GF2694@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Zdenek Kotala wrote:
> Attached patch removes pg_dump dependency on postgres.h. The main reason
> for that was discussed there:
>
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php
>
> This fix contains several steps:
>
> 1) I removed sugar word from postgres.h and put them closer to consumer
> :-). I created include/catalog/genbki.h which contains sugar words - macros
> for correct catalog data processing. All catalogs file now include this
> header.
What's the point of this? I don't see what difference it makes from the
current situation. In particular I don't see it being included in any
new place.
The other two changes seem to be what was discussed:
> 2) I moved SEQ_MAXVALUE and SEQ_MINVALUE macros from sequence.h to
> postgres_config_manual.h
>
> 3) I created two new headers pg_type_fn.h and pg_proc_fn.h and I moved all
> extern function definition from related headers into them.
--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
One man's impedance mismatch is another man's layer of abstraction.
(Lincoln Yeoh)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-11-06 16:59:34 | Re: regtype sorting broken in 8.3 |
Previous Message | Tom Lane | 2007-11-06 16:37:38 | Re: Opinion / advice needed for TODO: function params ref by name |
From | Date | Subject | |
---|---|---|---|
Next Message | Zdenek Kotala | 2007-11-06 17:43:30 | Re: Fix pg_dump dependency on postgres.h |
Previous Message | Magnus Hagander | 2007-11-06 14:27:07 | Re: krb_match_realm |