| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Configurable file mode mask |
| Date: | 2018-03-23 16:26:47 |
| Message-ID: | 461b0b2d-1927-08a5-89ba-c3f4bb222b5b@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
On 3/23/18 10:36 AM, Peter Eisentraut wrote:
> I have committed a basic pg_resetwal test suite as part of another
> patch, so please adjust accordingly.
>
> It looks to me like your pg_resetwal tests contain a bit of useless
> copy-and-paste. For example, you are not using use Config, nor
> $tempdir, and you run $node->stop right after $node->start. Please
> clean that up a bit, or comment, if appropriate.
Yeah, definitely too much copy-paste going on.
The various start/stops were intended the ensure that PG actually starts
with the reset WAL. I see that these tests don't do them, though, so
perhaps that's not a good use of test time.
The pg_rewind tests work for my purposes but it seems worth preserving
the ones I wrote since there is no overlap.
I've attached a patch that integrates my tests with the current tests.
If you don't think they are worth adding then I'll just drop them from
my patchset.
Thanks,
--
-David
david(at)pgmasters(dot)net
| Attachment | Content-Type | Size |
|---|---|---|
| pgrewind-more-tests.patch | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2018-03-23 16:43:24 | Re: [PATCH] Verify Checksums during Basebackups |
| Previous Message | David Steele | 2018-03-23 16:21:34 | Re: PATCH: Exclude unlogged tables from base backups |