| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Configurable file mode mask |
| Date: | 2018-03-23 14:36:41 |
| Message-ID: | 793d24ff-0c43-d7d7-bd10-e6703c443ad4@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have committed a basic pg_resetwal test suite as part of another
patch, so please adjust accordingly.
It looks to me like your pg_resetwal tests contain a bit of useless
copy-and-paste. For example, you are not using use Config, nor
$tempdir, and you run $node->stop right after $node->start. Please
clean that up a bit, or comment, if appropriate.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2018-03-23 14:42:51 | Re: Odd procedure resolution |
| Previous Message | Alvaro Herrera | 2018-03-23 14:34:17 | Re: ON CONFLICT DO UPDATE for partitioned tables |