Re: PATCH: Configurable file mode mask

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Configurable file mode mask
Date: 2018-03-26 07:22:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Mar 23, 2018 at 12:26:47PM -0400, David Steele wrote:
> I've attached a patch that integrates my tests with the current tests.
> If you don't think they are worth adding then I'll just drop them from
> my patchset.

It seems to me that those tests have values (we can add more tests for
transaction ID and such in the future), but I would recommend to put
them in a separate file named like t/ for tests which
execute resets and checks their consistency on the cluster.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2018-03-26 07:33:56 Re: PATCH: Exclude unlogged tables from base backups
Previous Message Michael Paquier 2018-03-26 07:16:31 Re: Add default role 'pg_access_server_files'