| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fairywren hung in pg_basebackup tests |
| Date: | 2022-07-27 14:32:29 |
| Message-ID: | 45d0908e-da40-867c-ad8a-af87c87644eb@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-07-27 We 10:24, Alvaro Herrera wrote:
> On 2022-Jul-27, Andrew Dunstan wrote:
>
>> The msys dirent.h doesn't have a d_type field at all in a struct dirent.
>> I can see a number of ways of dealing with this, but the simplest seems
>> to be just to revert 5344723755, at least for msys, along with a comment
>> about why it's necessary.
> Hmm, what other ways there are? I'm about to push a change that
> duplicates the get_dirent_type call pattern and I was happy about not
> having that #ifdef there. Not that it's critical, but ...
The alternative I thought of would be to switch msys to using our
dirent.c. Probably not too hard, but certainly more work than reverting.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robins Tharakan | 2022-07-27 14:48:52 | autoprewarm worker failing to load |
| Previous Message | Alvaro Herrera | 2022-07-27 14:24:31 | Re: fairywren hung in pg_basebackup tests |