| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fairywren hung in pg_basebackup tests |
| Date: | 2022-07-27 14:58:44 |
| Message-ID: | 2890057.1658933924@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The alternative I thought of would be to switch msys to using our
> dirent.c. Probably not too hard, but certainly more work than reverting.
If you ask me, the shortest-path general-purpose fix is to insert
#if MSYS
if (pgwin32_is_junction(path))
return PGFILETYPE_DIR;
#endif
at the start of get_dirent_type. (I'm not sure how to spell the
#if test.) We could look at using dirent.c later, but I think
right now it's important to un-break the buildfarm ASAP.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-27 15:16:46 | Re: autoprewarm worker failing to load |
| Previous Message | Robins Tharakan | 2022-07-27 14:48:52 | autoprewarm worker failing to load |