| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fairywren hung in pg_basebackup tests |
| Date: | 2022-07-27 14:24:31 |
| Message-ID: | 20220727142431.35xf3grppsheg7dv@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jul-27, Andrew Dunstan wrote:
> The msys dirent.h doesn't have a d_type field at all in a struct dirent.
> I can see a number of ways of dealing with this, but the simplest seems
> to be just to revert 5344723755, at least for msys, along with a comment
> about why it's necessary.
Hmm, what other ways there are? I'm about to push a change that
duplicates the get_dirent_type call pattern and I was happy about not
having that #ifdef there. Not that it's critical, but ...
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-07-27 14:32:29 | Re: fairywren hung in pg_basebackup tests |
| Previous Message | Andrew Dunstan | 2022-07-27 14:15:54 | Re: fairywren hung in pg_basebackup tests |